Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't read swap files during evaluation #352252

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Don't read swap files during evaluation #352252

wants to merge 2 commits into from

Conversation

roberth
Copy link
Member

@roberth roberth commented Oct 30, 2024 •
edited
Loading

Provide a proper type error in the following situation. Otherwise, /dev/zero would be read during evaluation; see NixOS/nix#11764.

nix-repl> (nixos { swapDevices = [ "/dev/zero" ]; boot.loader.grub.enable = false; fileSystems."/".device = "x"; }).config.system.build.toplevel

       error: Definitions for swapDevices items must be submodules, normally either { device = "…"; } or { label = "…"; }, but got a definition that is just "/dev/zero"

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: module system About "NixOS" module system internals 6.topic: lib The Nixpkgs function library labels Oct 30, 2024
@roberth roberth mentioned this pull request Oct 30, 2024
Open
roberth
roberth commented Nov 6, 2024
View reviewed changes
lib/types.nix
typeMerge = t: null;
functor = (defaultFunctor name) // { wrapped = finalType; };
typeMerge = f':
let coercedType' = coercedType.typeMerge (f'.coercedType).functor;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably merge with either instead of a typeMerge, and support multiple coercion functions that way.

(not the original goal of this PR at all though...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: lib The Nixpkgs function library 6.topic: module system About "NixOS" module system internals 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/`
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

types.coercedTo does not support type merging
1 participant
@roberth